Description

• This PR attempts to make android PinchGestureHandler consistent with iOS's implementation. i.e. Do not move PinchHandler to end when a finger is lifted.
• This issue is discussed in detail over here Change Pinch Gesture Handler Behavior to transition to END state after one finger is taken off screen and one left #1214

I agree with the notion of preserving the platform behaviour on iOS but in case of android there's no native pinch handler and some custom logic is already there in place, so I am not sure what behavior is correct. I am not sure whether this PR should be merged 😅

Approach

• End the handler on ACTION_UP. i.e. both fingers are lifted.
• Do not fire scale detector on ACTION_POINTER_UP. Read more in the comment

Test plan

• We can test it with the below snippet. Pinch handler will only move to end state when both the fingers are lifted.
• This gist can also be tested. With the changes in this PR, the gist code will run same in both the platforms.

const handler = useAnimatedGestureHandler<PinchGestureHandlerGestureEvent>({
    onActive(e) {
      console.log("Active")
    },
    onEnd(e) {
      console.log("Ended")
    }
});


// Attach the handler to PinchGestureHandler
<PinchGestureHandler onGestureEvent={handler}>
      <Animated.View
        style={{ height: 300, width: 300, backgroundColor: "pink" }}
      />
</PinchGestureHandler>